Repository navigation
Order-edge claims: assert A4's admission-wall refusal, not the pre-A4 order-absent reason - #12939
Merged
Merged
Conversation
…ather than the pre-A4 order-absent reason Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the three claims that #12514's merge-group differential found passing at base and failing at head, with #12770 (A4) between them. Measured red on main
224cdc4623f: each returnedfalse.Root cause: A4 moved where the refusal happens; no product behaviour broke
A4 (
v2.std.nodearrow_signature_order_conforms→arrow_domain_binds_a_name) makes anArrowwhose domain binds names but carries no order edge ill formed at Node admission. Sov2.std.arrow_signaturearrow_declared_parameter_ordernow answersArrowParameterOrderMalformedfor that shape, where before A4 it answeredArrowParameterOrderAbsent. Each claim read the old answer.emit.produced_item_parameter_order.an_item_with_parameters_and_no_order_refuses_typedproduced_decl_render_parameter_order_absentproduced_decl_render_parameter_order_malformedemit.realized_closure_parameter_order.a_closure_with_named_parameters_and_no_order_refuses_typedtarget_value_expr_reason_closure_parameter_order_absenttarget_value_expr_reason_closure_parameter_order_malformedinterface_summary.interface_summary_firewall.export_signature_host_seam_mints_no_order_edgeAbsentMalformedIn each case the input is still refused with a typed reason; the refusal now comes earlier, at the wall.
The re-statements (the discrimination is kept)
ArrowParameterOrderMalformedat the admission wall), then the typed_malformedrefusal. They still red if the renderer or closure realizer ever accepts the order-less form.export_signature_factsis order-less on purpose and consumed only throughexport_signature_declared_facts. It now asserts this structurally: no edge carriesarrow_signature_order_label. It also asserts the raw shape readsMalformedon its own, which is why the only consumer is the lift, the one constructor that makes it well formed. Its neighbourexported_signature_carries_named_binders_and_declared_orderstill pins that the lifted signature carries the declared order.All three modules are green on a remote run (19 claims), including the unchanged neighbours.
🤖 Generated with Claude Code